Feature/api delete #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
os-rss
commented
Aug 13, 2023
os-rss
commented
- refactoring of a storage module activating
- added new 'delete' api endpoint
- refactored and added api logic unit tests
os-esh
reviewed
Aug 14, 2023
| global DATASTORE_MODULE = let | ||
| const DATASTORE_MODULE = Ref{Module}() | ||
|
|
||
| begin |
There was a problem hiding this comment.
Why is there a begin block, is it necessary?
There was a problem hiding this comment.
Not necessary but logically combines the code
os-esh
approved these changes
Aug 14, 2023
os-rss
force-pushed
the
feature/api_delete
branch
from
2fe531b
to
058babe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.